Provide cmake override for shared-lib name #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
=======================================
Coverage 91.22% 91.22%
=======================================
Files 185 185
Lines 42435 42435
=======================================
Hits 38710 38710
Misses 3725 3725 Continue to review full report at Codecov.
|
|
Thanks, libsvlang seems like a reasonable workaround. I'll probably just make that the default but having the option doesn't hurt. |
mayhem-bot
pushed a commit
to mayhemheroes/slang
that referenced
this pull request
Nov 6, 2022
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #646, this PR provides a solution to the packaging issue, by adding a new variable SLANG_SHARED_LIB_NAME allowing a command line method for renaming the shared-lib during distribution packaging.
Since "s-lang" is in the dependency tree for NetworkManager most distros will have libslang.so installed already. I'll be using "libsvlang.so" for Arch Linux packaging.