Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stdc++fs flag since it's no longer needed for modern compilers #555

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Kuree
Copy link
Contributor

@Kuree Kuree commented Jun 24, 2022

No description provided.

@MikePopoloski
Copy link
Owner

I still ensure that slang builds with gcc-8 to make life easier for users on older systems. It would be nice to bump the minimum gcc version at some point but not sure when that will be. If this is causing problems for you, your PR will need to be more selective about when it includes the flag.

@Kuree
Copy link
Contributor Author

Kuree commented Jun 24, 2022

Thanks for the suggestion. I will add cmake check to add the flag if the version is below requirement.

The reason I'm filing this PR is that recent clang on Windows doesn't take -lstdc++fs flag anymore, see here.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #555 (50bb482) into master (8866ee6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #555   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files         183      183           
  Lines       42901    42901           
=======================================
  Hits        38361    38361           
  Misses       4540     4540           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8866ee6...50bb482. Read the comment docs.

@MikePopoloski MikePopoloski merged commit 3f6e637 into MikePopoloski:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants