Fix some clang-tidy warnings

MikePopoloski · Apr 21, 2024 · cd3c516 · cd3c516
1 parent 9b8d7d6
commit cd3c516
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/include/slang/ast/ScriptSession.h b/include/slang/ast/ScriptSession.h
@@ -31,7 +31,7 @@ class SLANG_EXPORT ScriptSession {
     CompilationUnitSymbol& scope;
 
     /// Constructs a new ScriptSession.
-    explicit ScriptSession(const Bag& options = {});
+    explicit ScriptSession(Bag options = {});
 
     /// Tries to evaluate the given snippet of SystemVerilog code
     /// and returns the result as a constant value.

diff --git a/source/ast/ScriptSession.cpp b/source/ast/ScriptSession.cpp
@@ -25,8 +25,8 @@ static Bag& createOptions(Bag& options) {
     return options;
 }
 
-ScriptSession::ScriptSession(const Bag& options) :
-    options(options), compilation(createOptions(this->options)),
+ScriptSession::ScriptSession(Bag options) :
+    options(std::move(options)), compilation(createOptions(this->options)),
     scope(compilation.createScriptScope()), astCtx(scope, LookupLocation::max),
     evalContext(astCtx, EvalFlags::IsScript) {
     evalContext.pushEmptyFrame();

diff --git a/source/ast/builtins/ArrayMethods.cpp b/source/ast/builtins/ArrayMethods.cpp
@@ -1023,7 +1023,7 @@ class ArrayMapMethod : public SystemSubroutine {
                 if (!cv)
                     return nullptr;
 
-                results.emplace(std::move(key), std::move(cv));
+                results.emplace(key, std::move(cv));
             }
             return results;
         }

diff --git a/source/ast/symbols/ParameterSymbols.cpp b/source/ast/symbols/ParameterSymbols.cpp
@@ -136,8 +136,10 @@ const ConstantValue& ParameterSymbol::getValue(SourceRange referencingRange) con
 }
 
 bool ParameterSymbol::isImplicitString(SourceRange referencingRange) const {
-    if (!value)
+    if (!value) {
         getValue(referencingRange);
+        SLANG_ASSERT(value);
+    }
     return fromStringLit || value->bad();
 }