-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make package safe for Swift 6 #50
Conversation
@MihaelIsaev there's a |
@ptoffy Have you tried it in action with Swift 6? I don’t have a chance to test it right now, but if everything works well, I’m ready to merge and tag it as v3. |
@ptoffy Have you tried it in action with Swift 6? |
Sorry @MihaelIsaev missed this. I have barely tried it locally and yet have to try it in a staging/prod environment, it will likely be this week. I'd suggest tagging a beta for now |
@ptoffy Thank you very much for your contribution! |
So after #48 and the introduction of Swift 6, some
@unchecked Sendable
annotations were added. While this compiles, it's not the correct way to approach the safety concerns introduced by Swift 6. This PR attempts to fix that by (over?)annotating the package withSendable
. I think this is a thing that should be done before releasing the latest major version as we're free to make breaking changes.The PR is currently in a semi-finished state as it should work as it is, but it's difficult to tell without tests. I also think that some improvements can be made to this solution as we do still have a few
class
es and mutable state around but I'm open to discussions about itAlso adds a build workflow for main and PRs