Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve subscribed topics #43

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

chinh-tran
Copy link
Contributor

Retrieves the subscribed topics for a given token as documented here:
https://developers.google.com/instance-id/reference/server?hl=en#get_information_about_app_instances

@MihaelIsaev
Copy link
Owner

@chinh-tran thanks for the contribution!

Screenshot 2024-03-14 at 18 22 16

I guess there should be only one method without underscore. Underscored methods usually expected to be private, but seems there is no need for the second private underscored method. Could you please leave only one public method without underscore and I will merge your pull request. Thanks

@chinh-tran
Copy link
Contributor Author

@chinh-tran thanks for the contribution!

Screenshot 2024-03-14 at 18 22 16 I guess there should be only one method without underscore. Underscored methods usually expected to be private, but seems there is no need for the second private underscored method. Could you please leave only one public method without underscore and I will merge your pull request. Thanks

@MihaelIsaev Thanks for the feedback! I've updated the code.

@MihaelIsaev MihaelIsaev merged commit f84d48a into MihaelIsaev:master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants