Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spec: DragStarting API #4871
Add Spec: DragStarting API #4871
Changes from all commits
b2b2634
74e7ca0
ec4af35
d7bfa12
58f6596
042c2b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the DropSource implementation going to likely be common among callers / boilerplate and we should include it in the sample? Or its really app dependent what the drop source looks like? Please either show the impl or add a comment here saying that its up to the app to create its own IDropSource here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the sample app, it is pretty boilerplate. I feel conflicted about adding it because having an IDropSource is more 'how to do ole drag drop' less 'how to use this event'. If we included this, we could/should also include that call to OleInitialize to make clear in the code block what steps are necessary to perform DoDragDrop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OleInitialize call was also weird because most host apps won't do that. They'll call it once at app start up not in the middle of drag and drop code. And we want the sample code to represent actual code an app dev would do.
For IDropSource maybe then just a comment saying its up to the app to implement this and a link to MSDN doc about that (if we have a good one)