Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more word delimiter examples #759

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

zadjii-msft
Copy link
Contributor

Copy link

Learn Build status updates of commit 1215fbd:

💡 Validation status: suggestions

File Status Preview URL Details
TerminalDocs/customize-settings/interaction.md 💡Suggestion View Details

TerminalDocs/customize-settings/interaction.md

  • Line 96, Column 1: [Suggestion: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:


| Terminal | Delimiters |
|----------------|-------------------------|
| Xterm | "$'()*;<>[\\]^`{|} |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put these in code backticks? it may make it easier to copy or see

Comment on lines 98 to 103
| Xterm | "$'()*;<>[\\]^`{|} |
| Gnome Terminal | !" $'()*:;<>[]^`{|} |
| Konsole | !" $'()*,;<>[\\]^`{|} |
| Rxvt | &();<>| |
| Alacritty | "'(),:<>[]`{|} |
| Kitty | !" $'()*,:;<>[\\]^`{|} |
Copy link
Contributor

@DHowett DHowett Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Xterm | "$'()*;<>[\\]^`{|} |
| Gnome Terminal | !" $'()*:;<>[]^`{|} |
| Konsole | !" $'()*,;<>[\\]^`{|} |
| Rxvt | &();<>| |
| Alacritty | "'(),:<>[]`{|} |
| Kitty | !" $'()*,:;<>[\\]^`{|} |
| Xterm | `"$'()*;<>[\\]^`{|}` |
| Gnome Terminal | `!"$'()*:;<>[]^`{|}` |
| Konsole | `!"$'()*,;<>[\\]^`{|}` |
| Rxvt | `&();<>|` |
| Alacritty | `"'(),:<>[]`{|}` |
| Kitty | `!"$'()*,:;<>[\\]^`{|}` |

with \\. I deleted all the spaces because space is always a delimiter in WT

Copy link
Contributor

@DHowett DHowett Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Xterm | "$'()*;<>[\\]^`{|} |
| Gnome Terminal | !" $'()*:;<>[]^`{|} |
| Konsole | !" $'()*,;<>[\\]^`{|} |
| Rxvt | &();<>| |
| Alacritty | "'(),:<>[]`{|} |
| Kitty | !" $'()*,:;<>[\\]^`{|} |
| Xterm | `"$'()*;<>[\]^`{|}` |
| Gnome Terminal | `!"$'()*:;<>[]^`{|}` |
| Konsole | `!"$'()*,;<>[\]^`{|}` |
| Rxvt | `&();<>|` |
| Alacritty | `"'(),:<>[]`{|}` |
| Kitty | `!"$'()*,:;<>[\]^`{|}` |

with just \ (which works for the SUI) (spaces as above)

Copy link

Learn Build status updates of commit 69169c5:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/interaction.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@DHowett DHowett merged commit 19a1de8 into main Apr 23, 2024
2 checks passed
@DHowett DHowett deleted the dev/migrie/613-more-word-delims branch April 23, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more examples for wordDelimiters
3 participants