Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 8.0.0-preview.1 changelog #314

Merged

Conversation

gathogojr
Copy link
Collaborator

Add 8.0.0-preview.1 changelog

Copy link
Contributor

Learn Build status updates of commit ff060f4:

⚠️ Validation status: warnings

File Status Preview URL Details
Odata-docs/changelog/odatalib-8x.md ⚠️Warning View Details
Odata-docs/TOC.yml ✅Succeeded View

Odata-docs/changelog/odatalib-8x.md

  • Line 4, Column 9: [Warning: author-not-found - See documentation] Invalid value for author: 'jogathog' is not a valid GitHub ID.
  • Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'gathogojr' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:


## [8.0.0-preview.1](https://github.com/OData/odata.net/releases/tag/8.0.0-preview.1)

Starting version 8, OData lib will only target .NET Core framework.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Starting version 8, OData lib will only target .NET Core framework.
Starting version 8, OData lib will only target .NET Core.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Starting version 8, OData lib will only target .NET Core framework.
Starting version 8, OData lib will only target .NET 8 and later.

I think .NET Core may be confusing since modern .NET versions have removed the "Core" part from the name.

Copy link
Contributor

@paulodero paulodero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer add specific PR links to the changelog?

@gathogojr
Copy link
Collaborator Author

We no longer add specific PR links to the changelog?

@paulodero I considered that but particularly for preview I found it might be messy/limiting to link to pull request while also trying to be as detailed as necessary. As many as 10 bullet points can link to the same pull request and there's no easy means to link to a bullet point to the particular section of code that implements the change.

@gathogojr gathogojr force-pushed the docs/add-8_0_0-preview_1-changelog branch from ff060f4 to 4c40a37 Compare April 26, 2024 14:26
Copy link
Contributor

Learn Build status updates of commit 4c40a37:

⚠️ Validation status: warnings

File Status Preview URL Details
Odata-docs/changelog/odatalib-8x.md ⚠️Warning View Details
Odata-docs/TOC.yml ✅Succeeded View

Odata-docs/changelog/odatalib-8x.md

  • Line 4, Column 9: [Warning: author-not-found - See documentation] Invalid value for author: 'jogathog' is not a valid GitHub ID.
  • Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'gathogojr' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gathogojr gathogojr force-pushed the docs/add-8_0_0-preview_1-changelog branch from 4c40a37 to 062e57a Compare April 26, 2024 14:29
Copy link
Contributor

Learn Build status updates of commit 062e57a:

✅ Validation status: passed

File Status Preview URL Details
Odata-docs/changelog/odatalib-8x.md ✅Succeeded View
Odata-docs/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gathogojr gathogojr force-pushed the docs/add-8_0_0-preview_1-changelog branch from 062e57a to 7da9cad Compare April 26, 2024 14:35
Copy link
Contributor

Learn Build status updates of commit 7da9cad:

✅ Validation status: passed

File Status Preview URL Details
Odata-docs/changelog/odatalib-8x.md ✅Succeeded View
Odata-docs/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gathogojr gathogojr force-pushed the docs/add-8_0_0-preview_1-changelog branch from 7da9cad to 29ad0af Compare April 26, 2024 15:13
Copy link
Contributor

Learn Build status updates of commit 29ad0af:

✅ Validation status: passed

File Status Preview URL Details
Odata-docs/changelog/odatalib-8x.md ✅Succeeded View
Odata-docs/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gathogojr gathogojr merged commit f2761c4 into MicrosoftDocs:main Apr 26, 2024
2 checks passed
@gathogojr gathogojr deleted the docs/add-8_0_0-preview_1-changelog branch April 26, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants