Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep update docs #299

Merged

Conversation

ElizabethOkerio
Copy link
Contributor

No description provided.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 621cfed:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
Odata-docs/client/bulk-update-operations.md ❌Error Details

Odata-docs/client/bulk-update-operations.md

  • Line 12, Column 17: [Error: include-not-found] Invalid include link: '../includes/appliesto-odataclient-v7.16.0.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit a7f56b5:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
Odata-docs/client/bulk-update-operations.md ❌Error Details
Odata-docs/TOC.yml 💡Suggestion Details

Odata-docs/client/bulk-update-operations.md

  • Line 12, Column 17: [Error: include-not-found] Invalid include link: '../includes/appliesto-odataclient-v7.16.0.md'.

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit fd13bf9:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b522217:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c1cd285:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 0721fe1:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 415e95f:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ElizabethOkerio ElizabethOkerio force-pushed the feature/delta_patch_in_odata_client branch from 415e95f to 9347766 Compare July 3, 2023 08:47
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 9347766:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 6432f4c:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c4bc03e:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 292, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 374, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

## Things to Note:
When calling the `BulkUpdateAsync` method, you need to pass in the top-level objects that you want to perform a bulk update on.

If the request gets processed successfully, the `DataServiceResponse` returned from the call to `BulkUpdateAsync` will have all the `ChangeOperationResponse`'s for all the operations in the bulk update request. If any of the operations failed, then the failed operation's `ChangeOperationResponse`'s Descriptor's `SaveResultWasProcessed` value will be `Unchanged`. Also, the Descriptor's `SaveError` property will have the error of the failed operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an example where you show how to handle a DataServiceResponse

@gathogojr gathogojr requested review from KenitoInc and xuzhg September 4, 2023 04:26
## Things to Note:
When calling the `BulkUpdateAsync` method, you need to pass in the top-level objects that you want to perform a bulk update on.

If the request gets processed successfully, the `DataServiceResponse` returned from the call to `BulkUpdateAsync` will have all the `ChangeOperationResponse`'s for all the operations in the bulk update request. If any of the operations failed, then the failed operation's `ChangeOperationResponse`'s Descriptor's `SaveResultWasProcessed` value will be `Unchanged`. Also, the Descriptor's `SaveError` property will have the error of the failed operation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could simulate such a failure and attach a screenshot of Visual Studio with a view of the error expanded.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit b53308b:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/client/bulk-update-operations.md 💡Suggestion View Details
Odata-docs/TOC.yml 💡Suggestion View Details

Odata-docs/client/bulk-update-operations.md

  • Line 1, Column 1: [Suggestion: uhf-header-id-missing] uhfHeaderID should not be null; specify the uhfHeaderID in global metadata of docfx.json file.

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 7d19edf:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/client/bulk-update-operations.md 💡Suggestion View Details
Odata-docs/TOC.yml 💡Suggestion View Details

Odata-docs/client/bulk-update-operations.md

  • Line 1, Column 1: [Suggestion: uhf-header-id-missing] uhfHeaderID should not be null; specify the uhfHeaderID in global metadata of docfx.json file.

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 94c877b:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/assets/descriptor-status.png ✅Succeeded View
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ddb5e8e:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/assets/descriptor-status.png ✅Succeeded View
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 0b456dd:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/assets/descriptor-status.png ✅Succeeded View
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Collaborator

@gathogojr gathogojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments otherwise LGTM

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 2a5b0bd:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/assets/descriptor-status.png ✅Succeeded View
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 2506a03:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/assets/descriptor-status.png ✅Succeeded View
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 37e501e:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/assets/descriptor-status.png ✅Succeeded View
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 15928d7:

💡 Validation status: suggestions

File Status Preview URL Details
Odata-docs/TOC.yml 💡Suggestion View Details
Odata-docs/assets/descriptor-status.png ✅Succeeded View
Odata-docs/client/bulk-update-operations.md ✅Succeeded View

Odata-docs/TOC.yml

  • Line 294, Column 17: [Suggestion: link-broken - See documentation] Link '/odata/odatalib/using-utf8jsonwriter-for-better-performance' points to a page that doesn't exist. Check the path or URL and update the link.
  • Line 376, Column 15: [Suggestion: link-broken - See documentation] Link '/odata/client/bulk-update-operations' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites. If you think the validation result is a false alarm, please use SiteHelp with option 'Content authoring and publishing -> False alarm on broken link validation' to report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gathogojr gathogojr merged commit 9c6f147 into MicrosoftDocs:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants