Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Electron 0.37.x #2559

Merged
merged 33 commits into from
Apr 13, 2016
Merged

Update to Electron 0.37.x #2559

merged 33 commits into from
Apr 13, 2016

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jan 30, 2016

Fixes the following issues:

Might have impact on following issues on blurriness:

Updates:

  • Chrome from 45 to 49
  • node.js from 4.1.1 to 5.10.0
  • libuv from 1.7.4 to 1.8.0

@1dot75cm
Copy link

Please fix this issue. I try to stripping electron from vscode rpm package. It return following error.

RPM spec: http://copr-dist-git.fedorainfracloud.org/cgit/mosquito/test/vscode.git/tree/vscode.spec?id=17ce85d650470e023ff37e7412d62c5aa222b304
RPM: https://copr.fedorainfracloud.org/coprs/mosquito/test/build/163492/

Version 0.10.11
Commit 8b7f21e10bf69745bde4330a337e9501972e983b
Shell 0.36.8
Renderer 47.0.2526.110
Node 5.1.1
$ dnf install https://copr-be.cloud.fedoraproject.org/results/mosquito/test/fedora-23-x86_64/00163492-vscode/vscode-0.10.11-1.fc23.x86_64.rpm
$ export ELECTRON_ENABLE_LOGGING=1
$ export ELECTRON_ENABLE_STACK_DUMPING=1
$ electron /usr/lib64/vscode
[6978:0227/175217:INFO:CONSOLE(133360)] "IRequestService.makeRequest: Url is required.: Error: IRequestService.makeRequest: Url is required.
    at RequestService.makeRequest (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:137627:23)
    at GalleryService.queryCache (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:121102:40)
    at GalleryService.query (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:121057:30)
    at ExtensionTipsService._getAvailableExtensions (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:92773:41)
    at ExtensionTipsService._init (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:92735:46)
    at new ExtensionTipsService (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:92705:18)
    at create (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:5252:14)
    at file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:61565:45
    at AccessLock.runUnlocked (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:61393:24)
    at ServicesMap.createInstance (file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js:61564:31)", source: file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js (133360)
......
[6978:0227/175219:INFO:CONSOLE(109401)] "%c[Plugin Host]", source: file:////usr/lib64/vscode/out/vs/workbench/workbench.main.js (109401)

@bpasero
Copy link
Member Author

bpasero commented Feb 29, 2016

@1dot75cm we are currently blocked by a native crash in V8: electron/electron#4299

@bpasero bpasero changed the title Update to Electron 0.36.x Update to Electron 0.37.x Mar 13, 2016
@bpasero bpasero added this to the April 2016 milestone Mar 14, 2016
@felixfbecker
Copy link
Contributor

Node 5, yes please...

@1dot75cm
Copy link

1dot75cm commented Apr 6, 2016

Commit 0787cde with electron 0.36.11 is work fine on Fedora 23.
RPMS: https://copr.fedorainfracloud.org/coprs/mosquito/vscode/build/173746/

The electron 0.37.4 with 0787cde still crashes. @bpasero
RPMS without node-weak by disable-weak.patch: https://copr.fedorainfracloud.org/coprs/mosquito/test/build/173751/

Update: I removed the value of aiConfig from product.json file. It can work properly.

version 0.10.14
commit 0787cde294d5eadf12dfd1ad38f2996241021f0c
date 2016-04-06T20:54:31.495Z
Shell 0.37.4
renderer 49.0.2623.75
Node 6.0.0-pre
$ vim product.json
...
"aiConfig": {
    "key": "",
    "asimovKey": ""
},
...

@bpasero
Copy link
Member Author

bpasero commented Apr 7, 2016

We do not recommend to build VS Code with newer Electron version until VS Code itself moved forward!

@bpasero bpasero merged commit 84abe71 into master Apr 13, 2016
isidorn pushed a commit that referenced this pull request Apr 15, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants