Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac: Auto-update prevents to store settings of session #172

Closed
bpasero opened this issue Nov 19, 2015 · 5 comments
Closed

Mac: Auto-update prevents to store settings of session #172

bpasero opened this issue Nov 19, 2015 · 5 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
April 2016

Comments

@bpasero
Copy link
Member

bpasero commented Nov 19, 2015

Whenever I install an update (prompted by VS Code) it doesn't open the same file I had opened before.

I think this is caused by a prompt process.exit() that leaves VS Code (or actually Chromium) no chance to persist the local storage to disk. It is reproducible by calling Lifecycle.quit() and from the done handler call process.exit().

Have to follow up with Electron to understand this better.
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Nov 19, 2015
@bpasero bpasero self-assigned this Nov 19, 2015
@joaomoreno
Copy link
Member

👍

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Nov 19, 2015
@bpasero bpasero modified the milestone: Dec 2015 Nov 26, 2015
@bpasero
Copy link
Member Author

bpasero commented Dec 1, 2015

Might be fixed with Electron update.

@bpasero bpasero closed this as completed Dec 1, 2015
@bpasero
Copy link
Member Author

bpasero commented Dec 2, 2015

Nope...

@bpasero bpasero reopened this Dec 2, 2015
@bpasero bpasero modified the milestones: Backlog, Dec 2015 Dec 2, 2015
@weinand
Copy link
Contributor

weinand commented Jan 20, 2016

@bpasero since this is the most annoying problem with VSCode, I have to label this bug as "Important"...

@weinand weinand added the important Issue identified as high-priority label Jan 20, 2016
@weinand weinand mentioned this issue Jan 20, 2016
Closed
@bpasero
Copy link
Member Author

bpasero commented Jan 20, 2016

@weinand thats fine, but note that there is nothing we can do until we update to Electron 0.36.x.

@bpasero bpasero modified the milestones: Feb 2016, Backlog Jan 20, 2016
@bpasero bpasero modified the milestones: Backlog, Feb 2016 Feb 2, 2016
This was referenced Mar 14, 2016
Merged
Closed
@bpasero bpasero modified the milestones: April 2016, Backlog Apr 14, 2016
@bpasero bpasero closed this as completed Apr 14, 2016
@bpasero bpasero assigned weinand and unassigned bpasero Apr 14, 2016
@weinand weinand added the verified Verification succeeded label May 2, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
April 2016
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @weinand