Merge pull request #176 from itchyny/fix-modulo-nan

Fix modulo operator on NaN to emit NaN

src/intrinsic/binary.rs

@@ -142,6 +142,9 @@ fn modulo(lhs: Value, rhs: Value) -> Result<Value, QueryExecutionError> {
     use Value::*;
     Ok(match (lhs, rhs) {
         (Number(lhs), Number(rhs)) => {
+            if lhs.is_nan() || rhs.is_nan() {
+                return Ok(Value::number(f64::NAN));
+            }
             let rhs = number_to_i64(rhs);
             if rhs == 0 {
                 return Err(QueryExecutionError::DivModByZero);

tests/hand_written/mod.rs

@@ -639,6 +639,22 @@ test!(
     "#
 );
 
+test!(
+    modulo_nan,
+    r#"
+    (1, nan) % (1, nan) | isnan
+    "#,
+    r#"
+    null
+    "#,
+    r#"
+    false
+    true
+    true
+    true
+    "#
+);
+
 test!(
     delete1,
     r#"