Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/for getting saving as feature #22

Merged
merged 19 commits into from
Jan 21, 2024
Merged

Refactor/for getting saving as feature #22

merged 19 commits into from
Jan 21, 2024

Conversation

MhouneyLH
Copy link
Owner

Summary

  • adding some more useful tests
  • renaming of constants and other variables
  • refactor architecture to get the saving-mechanism to a working state

Other

MhouneyLH and others added 18 commits January 6, 2024 18:58
@MhouneyLH
feat: got saving mechanism to a working state
946bdfa
@MhouneyLH
fix: use different path for config file
241aba1
@MhouneyLH
refactor: change timespan to keystroke class
88c1760
@MhouneyLH
refactor: adjust keystrokeRepository to new structure
8c9af5f
@MhouneyLH
refactor: adjust configuration loader
dc95a69
@MhouneyLH
refactor: adjust all other things except the checking of which timesp…
b5c471d 
…an some keystrokes belong to
@MhouneyLH
feat: add count methods for every timespan and rework some stuff
6651fda
@MhouneyLH
fix: averageWPM method
b06fa92
@MhouneyLH
fix: use better algorithm for getting the average words per Minute
cf86d70
@MhouneyLH
fix: status bar text just started updating after using a keystroke
2219296
@MhouneyLH
test: WIP
6b07ca5
test: add for keystroke
514063f
@MhouneyLH
test: add for keystroke-repository
98fe033
@MhouneyLH
test: add keystroke_analytics_message tests
dd9d200
@MhouneyLH
test: add for words_per_minute_calculator
4e9258b
@MhouneyLH
test: add for status bar items and create generateKeystroke util meth…
6ba97a2 
…od for tests
@MhouneyLH
feat: working state for wpm also after saving
552b1f6
@MhouneyLH
refactor: adjust all wpm based tests to work properly
492c4e5
@MhouneyLH MhouneyLH added enhancement New feature or request refactoring labels Jan 21, 2024
@MhouneyLH MhouneyLH self-assigned this Jan 21, 2024
@MhouneyLH MhouneyLH force-pushed the refactor/for_getting_saving_as_feature branch from 69b4a38 to a567bee Compare January 21, 2024 14:21
@MhouneyLH MhouneyLH merged commit c5bc211 into develop Jan 21, 2024
4 checks passed
@MhouneyLH MhouneyLH deleted the refactor/for_getting_saving_as_feature branch January 21, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MhouneyLH MhouneyLH

Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MhouneyLH