Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, HAS CONCEPTUAL ISSUES
Technical Description
The inlining pass present in dawn (
PassInlining
) is not designed to inline computations within stencils, but inlines stencil functions. It is also untested. This PR is a proof of concept a simple inlining pass that argues over computations within a single stencil scope. It performs one time temporary inlining if and only if the result is story into temporary field or var that is only written to once.Example
is inlined to
No attempt is made to inline e.g.
Testing
Two tests reflecting the examples above are introduced.
Dependencies
This PR is independent.