This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
Woodpile37
approved these changes
May 22, 2022
This comment was marked as spam.
This comment was marked as spam.
Woodpile37
approved these changes
May 23, 2022
Woodpile37
approved these changes
May 23, 2022
Woodpile37
approved these changes
May 23, 2022
Woodpile37
approved these changes
May 23, 2022
lokera666
approved these changes
Aug 20, 2022
Thank you for this pull request, but we are actively phasing out this package in favor of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines a bunch of improvements we had to do for etherscan to work better.
Etherscan requires API-keys to be used for a while now. With this commit adds a
apiKey
property to etherscan provider.The networks, specified in other parts of the code, use things like
mainnet
,goerli
etc. as specifier. these are available at etherscan through aapi-<network>
subdomains. This commit should make it easier to specify the network correctly.Before this commit only 403 error were handled by the subprovider. With this commit any unexpected status code is treated by errors.
There is a chance that errors are returned without message, in this case the callback is returned with null, indicating no error occurred. With this commit it is made sure that an error is always returned.
Before this commit an interval was running by merely instantiating Etherscan. Now it runs only if there is actually work that may be done.
We use configuration properties to fill the requests to etherscan. This commit allows to specify one as "undefined" and not break the request.
Callback API's usually return error instances in the first argument. With this commit every response is guaranteed to be an error instance
Etherscan has a convenient API to calculate the gas required for an operation. With this commit it can be used.