Update snap_getPreferences
#3093
Conversation
| */ | ||
| export type GetPreferencesResult = { | ||
| locale: string; | ||
| currency: string; | ||
| hideBalances: boolean; | ||
| useSecurityAlerts: boolean; | ||
| useSimulations: boolean; |
There was a problem hiding this comment.
| useSimulations: boolean; | |
| useTransactionSimulations: boolean; |
There was a problem hiding this comment.
It can be signatures as well, so that's why I kept it generic.
There was a problem hiding this comment.
Hmm, I feel like "simulations" is too generic, but I'm not sure if there's a good name for both 🤔
There was a problem hiding this comment.
How about simulateOnChainActions?
| @@ -13,9 +13,23 @@ export type GetPreferencesParams = never; | |||
| * @property locale - The user's selected locale. | |||
| * @property currency - The user's selected currency. | |||
| * @property hideBalances - Whether the user has chosen to hide balances. | |||
| * @property useSecurityAlerts - Whether to run transactions and signatures through blockaid. | |||
There was a problem hiding this comment.
Is this relevant for Snaps? They can't hook into Blockaid.
There was a problem hiding this comment.
Have no idea, maybe Solana team has plans to use blockaid? cc: @Montoya
There was a problem hiding this comment.
Yup they are integrating blockaid's API into the snap
There was a problem hiding this comment.
I think we should make it more generic and not mention any providers, our Snaps may choose to use Blockaid, but other Snaps could use other providers for "security alerts"
There was a problem hiding this comment.
Updated the description.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 506 506
Lines 11123 11123
Branches 1709 1709
=======================================
Hits 10554 10554
Misses 569 569 ☔ View full report in Codecov by Sentry. |
Yes please, we can just return true for all the new flags tbh |
Done |
Updating
snap_getPreferencesreturn type to include additional properties.Closes #3076