chore(deps-dev): bump @metamask/eslint-config from 12.1.0 to 13.0.0

.eslintrc.js

@@ -4,6 +4,7 @@ module.exports = {
   extends: ['@metamask/eslint-config'],
 
   parserOptions: {
+    project: true,
     tsconfigRootDir: __dirname,
   },
 
@@ -15,7 +16,7 @@ module.exports = {
     // This prevents importing Node.js builtins. We currently use them in
     // our codebase, so this rule is disabled. This rule should be disabled
     // in `@metamask/eslint-config-nodejs` in the future.
-    'import/no-nodejs-modules': 'off',
+    'import-x/no-nodejs-modules': 'off',
 
     // This prevents using the `console.log` and similar functions. All logging
     // should be done through the module logger, or `logError` function in
@@ -57,6 +58,88 @@ module.exports = {
         // triggers for class methods as well.
         'no-restricted-syntax': 'off',
 
+        // Copied from `@metamask/eslint-config-typescript` but modified to
+        // allow importing with PascalCase or camelCase again.
+        // TODO: Upstream this change.
+        '@typescript-eslint/naming-convention': [
+          'error',
+          {
+            selector: 'default',
+            format: ['camelCase'],
+            leadingUnderscore: 'allow',
+            trailingUnderscore: 'forbid',
+          },
+          {
+            selector: 'enumMember',
+            format: ['PascalCase'],
+          },
+          {
+            selector: 'import',
+            format: ['camelCase', 'PascalCase'],
+          },
+          {
+            selector: 'interface',
+            format: ['PascalCase'],
+            custom: {
+              regex: '^I[A-Z]',
+              match: false,
+            },
+          },
+          {
+            selector: 'objectLiteralMethod',
+            format: ['camelCase', 'PascalCase', 'UPPER_CASE'],
+          },
+          {
+            selector: 'objectLiteralProperty',
+            format: ['camelCase', 'PascalCase', 'UPPER_CASE'],
+          },
+          {
+            selector: 'typeLike',
+            format: ['PascalCase'],
+          },
+          {
+            selector: 'typeParameter',
+            format: ['PascalCase'],
+            custom: {
+              regex: '^.{3,}',
+              match: true,
+            },
+          },
+          {
+            selector: 'variable',
+            format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
+            leadingUnderscore: 'allow',
+          },
+          {
+            selector: 'parameter',
+            format: ['camelCase', 'PascalCase'],
+            leadingUnderscore: 'allow',
+          },
+          {
+            selector: [
+              'classProperty',
+              'objectLiteralProperty',
+              'typeProperty',
+              'classMethod',
+              'objectLiteralMethod',
+              'typeMethod',
+              'accessor',
+              'enumMember',
+            ],
+            format: null,
+            modifiers: ['requiresQuotes'],
+          },
+        ],
+
+        // Don't require explicit return types.
+        // TODO: Upstream this change(?).
+        '@typescript-eslint/explicit-function-return-type': 'off',
+
+        // These rules cause a lot of false positives.
+        // TODO: Investigate why this is needed.
+        '@typescript-eslint/no-floating-promises': 'off',
+        '@typescript-eslint/no-redundant-type-constituents': 'off',
+
         // This allows importing the `Text` JSX component.
         '@typescript-eslint/no-shadow': [
           'error',
@@ -65,6 +148,16 @@ module.exports = {
           },
         ],
 
+        // Allow `||` in conditional tests and mixed logical expressions.
+        // TODO: Upstream this change.
+        '@typescript-eslint/prefer-nullish-coalescing': [
+          'error',
+          {
+            ignoreConditionalTests: true,
+            ignoreMixedLogicalExpressions: true,
+          },
+        ],
+
         // Without the `allowAny` option, this rule causes a lot of false
         // positives.
         '@typescript-eslint/restrict-template-expressions': [
@@ -75,6 +168,10 @@ module.exports = {
             allowNumber: true,
           },
         ],
+
+        // This is handled by the `@typescript-eslint/no-empty-function` rule.
+        // TODO: Upstream this change.
+        'no-empty-function': 'off',
       },
     },
 

package.json

@@ -72,24 +72,24 @@
     "@lavamoat/allow-scripts": "^3.0.4",
     "@metamask/auto-changelog": "^3.4.4",
     "@metamask/create-release-branch": "^3.0.0",
-    "@metamask/eslint-config": "^12.1.0",
-    "@metamask/eslint-config-jest": "^12.1.0",
-    "@metamask/eslint-config-nodejs": "^12.1.0",
-    "@metamask/eslint-config-typescript": "^12.1.0",
+    "@metamask/eslint-config": "^13.0.0",
+    "@metamask/eslint-config-jest": "^13.0.0",
+    "@metamask/eslint-config-nodejs": "^13.0.0",
+    "@metamask/eslint-config-typescript": "^13.0.0",
     "@metamask/utils": "^9.1.0",
     "@swc/core": "1.3.78",
     "@types/jest": "^27.5.1",
     "@types/node": "18.14.2",
-    "@typescript-eslint/eslint-plugin": "^5.42.1",
-    "@typescript-eslint/parser": "^5.42.1",
+    "@typescript-eslint/eslint-plugin": "^6.21.0",
+    "@typescript-eslint/parser": "^6.21.0",
     "chromedriver": "^127.0.0",
     "depcheck": "^1.4.7",
-    "eslint": "^8.27.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^27.1.5",
-    "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-n": "^15.7.0",
+    "eslint-plugin-import-x": "^0.5.1",
+    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
+    "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.1.1",
     "execa": "^5.1.1",

packages/create-snap/.eslintrc.js

@@ -12,6 +12,10 @@ module.exports = {
       globals: {
         snaps: true,
       },
+
+      rules: {
+        'n/no-sync': 'off',
+      },
     },
 
     {

packages/create-snap/package.json

@@ -53,26 +53,26 @@
   "devDependencies": {
     "@lavamoat/allow-scripts": "^3.0.4",
     "@metamask/auto-changelog": "^3.4.4",
-    "@metamask/eslint-config": "^12.1.0",
-    "@metamask/eslint-config-jest": "^12.1.0",
-    "@metamask/eslint-config-nodejs": "^12.1.0",
-    "@metamask/eslint-config-typescript": "^12.1.0",
+    "@metamask/eslint-config": "^13.0.0",
+    "@metamask/eslint-config-jest": "^13.0.0",
+    "@metamask/eslint-config-nodejs": "^13.0.0",
+    "@metamask/eslint-config-typescript": "^13.0.0",
     "@swc/core": "1.3.78",
     "@swc/jest": "^0.2.26",
     "@types/jest": "^27.5.1",
     "@types/node": "18.14.2",
     "@types/rimraf": "^3.0.0",
     "@types/yargs": "^17.0.24",
-    "@typescript-eslint/eslint-plugin": "^5.42.1",
-    "@typescript-eslint/parser": "^5.42.1",
+    "@typescript-eslint/eslint-plugin": "^6.21.0",
+    "@typescript-eslint/parser": "^6.21.0",
     "deepmerge": "^4.2.2",
     "depcheck": "^1.4.7",
-    "eslint": "^8.27.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^27.1.5",
-    "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-n": "^15.7.0",
+    "eslint-plugin-import-x": "^0.5.1",
+    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
+    "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",

packages/create-snap/src/cmds/init/index.ts

@@ -1,9 +1,9 @@
 import { logInfo } from '@metamask/snaps-utils';
 import type yargs from 'yargs';
 
+import { initHandler } from './initHandler';
 import builders from '../../builders';
 import type { YargsArgs } from '../../types/yargs';
-import { initHandler } from './initHandler';
 
 export const initCommand = {
   command: ['$0 [directory]'],

packages/create-snap/src/cmds/init/initHandler.test.ts

@@ -8,10 +8,10 @@ import { promises as fs } from 'fs';
 import pathUtils from 'path';
 import semver from 'semver';
 
-import { resetFileSystem } from '../../test-utils';
-import type { YargsArgs } from '../../types/yargs';
 import { initHandler } from './initHandler';
 import * as initUtils from './initUtils';
+import { resetFileSystem } from '../../test-utils';
+import type { YargsArgs } from '../../types/yargs';
 
 jest.mock('fs');
 

packages/create-snap/src/cmds/init/initHandler.ts

@@ -1,4 +1,4 @@
-// eslint-disable-next-line import/no-extraneous-dependencies
+// eslint-disable-next-line import-x/no-extraneous-dependencies
 import cliPackageJson from '@metamask/create-snap/package.json';
 import type { NpmSnapPackageJson } from '@metamask/snaps-utils';
 import {
@@ -12,7 +12,6 @@ import pathUtils from 'path';
 import type { SemVer } from 'semver';
 import semver from 'semver';
 
-import type { YargsArgs } from '../../types/yargs';
 import {
   buildSnap,
   cloneTemplate,
@@ -23,6 +22,7 @@ import {
   SNAP_LOCATION,
   yarnInstall,
 } from './initUtils';
+import type { YargsArgs } from '../../types/yargs';
 
 /**
  * Creates a new snap package, based on one of the provided templates. This

packages/create-snap/src/cmds/init/initUtils.test.ts

@@ -3,7 +3,6 @@ import childProcess from 'child_process';
 import { promises as fs } from 'fs';
 import pathUtils from 'path';
 
-import { resetFileSystem } from '../../test-utils';
 import {
   buildSnap,
   cloneTemplate,
@@ -14,6 +13,7 @@ import {
   yarnInstall,
   TEMPLATE_GIT_URL,
 } from './initUtils';
+import { resetFileSystem } from '../../test-utils';
 
 jest.mock('fs');
 

packages/examples/package.json

@@ -29,19 +29,19 @@
   "devDependencies": {
     "@lavamoat/allow-scripts": "^3.0.4",
     "@metamask/auto-changelog": "^3.4.4",
-    "@metamask/eslint-config": "^12.1.0",
-    "@metamask/eslint-config-jest": "^12.1.0",
-    "@metamask/eslint-config-nodejs": "^12.1.0",
-    "@metamask/eslint-config-typescript": "^12.1.0",
-    "@typescript-eslint/eslint-plugin": "^5.42.1",
-    "@typescript-eslint/parser": "^5.42.1",
+    "@metamask/eslint-config": "^13.0.0",
+    "@metamask/eslint-config-jest": "^13.0.0",
+    "@metamask/eslint-config-nodejs": "^13.0.0",
+    "@metamask/eslint-config-typescript": "^13.0.0",
+    "@typescript-eslint/eslint-plugin": "^6.21.0",
+    "@typescript-eslint/parser": "^6.21.0",
     "depcheck": "^1.4.7",
-    "eslint": "^8.27.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^27.1.5",
-    "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-n": "^15.7.0",
+    "eslint-plugin-import-x": "^0.5.1",
+    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
+    "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.1.1",
     "prettier": "^2.7.1",

packages/examples/packages/bip32/package.json

@@ -40,24 +40,24 @@
     "@jest/globals": "^29.5.0",
     "@lavamoat/allow-scripts": "^3.0.4",
     "@metamask/auto-changelog": "^3.4.4",
-    "@metamask/eslint-config": "^12.1.0",
-    "@metamask/eslint-config-jest": "^12.1.0",
-    "@metamask/eslint-config-nodejs": "^12.1.0",
-    "@metamask/eslint-config-typescript": "^12.1.0",
+    "@metamask/eslint-config": "^13.0.0",
+    "@metamask/eslint-config-jest": "^13.0.0",
+    "@metamask/eslint-config-nodejs": "^13.0.0",
+    "@metamask/eslint-config-typescript": "^13.0.0",
     "@metamask/snaps-cli": "workspace:^",
     "@metamask/snaps-jest": "workspace:^",
     "@swc/core": "1.3.78",
     "@swc/jest": "^0.2.26",
-    "@typescript-eslint/eslint-plugin": "^5.42.1",
-    "@typescript-eslint/parser": "^5.42.1",
+    "@typescript-eslint/eslint-plugin": "^6.21.0",
+    "@typescript-eslint/parser": "^6.21.0",
     "deepmerge": "^4.2.2",
     "depcheck": "^1.4.7",
-    "eslint": "^8.27.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^27.1.5",
-    "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-n": "^15.7.0",
+    "eslint-plugin-import-x": "^0.5.1",
+    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
+    "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",

packages/examples/packages/bip44/package.json

@@ -39,24 +39,24 @@
     "@jest/globals": "^29.5.0",
     "@lavamoat/allow-scripts": "^3.0.4",
     "@metamask/auto-changelog": "^3.4.4",
-    "@metamask/eslint-config": "^12.1.0",
-    "@metamask/eslint-config-jest": "^12.1.0",
-    "@metamask/eslint-config-nodejs": "^12.1.0",
-    "@metamask/eslint-config-typescript": "^12.1.0",
+    "@metamask/eslint-config": "^13.0.0",
+    "@metamask/eslint-config-jest": "^13.0.0",
+    "@metamask/eslint-config-nodejs": "^13.0.0",
+    "@metamask/eslint-config-typescript": "^13.0.0",
     "@metamask/snaps-cli": "workspace:^",
     "@metamask/snaps-jest": "workspace:^",
     "@swc/core": "1.3.78",
     "@swc/jest": "^0.2.26",
-    "@typescript-eslint/eslint-plugin": "^5.42.1",
-    "@typescript-eslint/parser": "^5.42.1",
+    "@typescript-eslint/eslint-plugin": "^6.21.0",
+    "@typescript-eslint/parser": "^6.21.0",
     "deepmerge": "^4.2.2",
     "depcheck": "^1.4.7",
-    "eslint": "^8.27.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^27.1.5",
-    "eslint-plugin-jsdoc": "^39.6.2",
-    "eslint-plugin-n": "^15.7.0",
+    "eslint-plugin-import-x": "^0.5.1",
+    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
+    "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.1.1",
     "jest": "^29.0.2",