Handle spawnSync errors in create-snap #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change from execSync to spawnSync didn't mock the new call properly, resulting in falsely passing tests. spawnSync doesn't throw when there's an error, it just returns an object all the time. This commit fixes the tests and the implementation to account for this difference.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
==========================================
- Coverage 96.19% 96.19% -0.01%
==========================================
Files 245 245
Lines 5892 5888 -4
Branches 960 964 +4
==========================================
- Hits 5668 5664 -4
Misses 224 224
☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Nov 3, 2023
FrederikBolding
pushed a commit
that referenced
this pull request
Nov 8, 2023
Note: merge this after #1916 When creating a new Snap using the create-snap CLI, we make an initial commit with the code of the template. This makes it easier for devs to see the changes they make as they start hacking on the template, without having to remember to make an initial commit manually. This is similar to what's done by other "create" projects such as CRA. Tested: <img width="590" alt="image" src="https://github.com/MetaMask/snaps/assets/3943143/fba9d2bd-8179-4bae-92ed-d30d0a7e937a">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change from execSync to spawnSync didn't mock the new call properly, resulting in falsely passing tests. spawnSync doesn't throw when there's an error, it just returns an object all the time. This commit fixes the tests and the implementation to account for this difference.