Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shell command injection in create-snap #1784

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Sep 26, 2023

This changes execSync to spawnSync so we directly invoque the command and pass individual arguments to it.

2023-09-26.16-09-33.mp4

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner September 26, 2023 14:17
@GuillaumeRx GuillaumeRx force-pushed the gr/fix-create-snap-escape branch from 7b8fd15 to 61b3eda Compare September 26, 2023 14:18
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8c93bc2) 95.88% compared to head (61b3eda) 95.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1784   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         239      239           
  Lines        5465     5465           
  Branches      850      850           
=======================================
  Hits         5240     5240           
  Misses        225      225           
Files Coverage Δ
packages/create-snap/src/cli.ts 100.00% <100.00%> (ø)
packages/create-snap/src/cmds/init/initUtils.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuillaumeRx GuillaumeRx merged commit 836be99 into main Sep 26, 2023
@GuillaumeRx GuillaumeRx deleted the gr/fix-create-snap-escape branch September 26, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants