Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused deps #1674

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Remove unused deps #1674

merged 2 commits into from
Aug 22, 2023

Conversation

FrederikBolding
Copy link
Member

Removes a bunch of unused dependencies that consumers of our packages don't need to install.

@FrederikBolding FrederikBolding requested a review from a team as a code owner August 18, 2023 10:35
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @types/[email protected]

@socket-security
Copy link

socket-security bot commented Aug 18, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/[email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore @metamask/[email protected]

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1674 (3254e90) into main (456afc2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1674   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         239      239           
  Lines        5400     5400           
  Branches      836      836           
=======================================
  Hits         5178     5178           
  Misses        222      222           

Mrtenz
Mrtenz previously approved these changes Aug 21, 2023
@FrederikBolding FrederikBolding merged commit 2b3a4cd into main Aug 22, 2023
@FrederikBolding FrederikBolding deleted the fb/remove-unused-deps branch August 22, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants