-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0.0 #276
7.0.0 #276
Conversation
53ae069
to
9e2787c
Compare
## [7.0.0] | ||
### Added | ||
- Integrate `PollingController` mixin into `SmartTransactionsController` and implement the abstract `_executePoll` method ([#237](https://github.com/MetaMask/smart-transactions-controller/pull/237)) | ||
- Validation can be now be circumvented by passing the `skipConfirm` option ([#271](https://github.com/MetaMask/smart-transactions-controller/pull/271)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big release! 😅 I tried my best to go through every change in every PR. I think I got it all. I realize some of the suggestions may conflict with one another, so let me know if it'd be easier for me to make them myself.
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog need entries for:
@dan437 Would you be able to help us out here? Is main
still releasable from your PoV?
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ |
@legobeat I've applied all of the suggestions I made above and also added entries for 279 and 282. I'm okay with merging this if we don't get a response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Blocked by Revert #274 #299
This has been merged after last update of changelog in this PR: |
I am okay to add two more PRs to this release. It seems like we will hold off until merging more PRs.
This is the release candidate for version 7.0.0.