Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.0 #276

Merged
merged 8 commits into from
Mar 19, 2024
Merged

7.0.0 #276

merged 8 commits into from
Mar 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 7.0.0.

## [7.0.0]
### Added
- Integrate `PollingController` mixin into `SmartTransactionsController` and implement the abstract `_executePoll` method ([#237](https://github.com/MetaMask/smart-transactions-controller/pull/237))
- Validation can be now be circumvented by passing the `skipConfirm` option ([#271](https://github.com/MetaMask/smart-transactions-controller/pull/271))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan437 There was a bit going on in #271.. Would appreciate your input in if I got the entries for it right or if something is overlooked.

@legobeat legobeat marked this pull request as ready for review February 22, 2024 09:20
@legobeat legobeat requested a review from a team as a code owner February 22, 2024 09:20
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big release! 😅 I tried my best to go through every change in every PR. I think I got it all. I realize some of the suggestions may conflict with one another, so let me know if it'd be easier for me to make them myself.

legobeat and others added 3 commits February 24, 2024 08:45
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog need entries for:

@dan437 Would you be able to help us out here? Is main still releasable from your PoV?

Copy link

socket-security bot commented Mar 13, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

View full report↗︎

@mcmire
Copy link
Contributor

mcmire commented Mar 13, 2024

@legobeat I've applied all of the suggestions I made above and also added entries for 279 and 282. I'm okay with merging this if we don't get a response.

mcmire
mcmire previously approved these changes Mar 13, 2024
@legobeat legobeat mentioned this pull request Mar 19, 2024
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legobeat
Copy link
Contributor

This has been merged after last update of changelog in this PR:

@mcmire mcmire dismissed legobeat’s stale review March 19, 2024 18:12

I am okay to add two more PRs to this release. It seems like we will hold off until merging more PRs.

@mcmire mcmire merged commit 521c2d8 into main Mar 19, 2024
16 checks passed
@mcmire mcmire deleted the release/7.0.0 branch March 19, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants