-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump @metamask/composable-controller
from ^3.0.0
to ^10.0.0
#10441
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
815f836
to
992908f
Compare
6209b1f
to
a519205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes for reviewers:
f501427
to
2c0475a
Compare
8e8fc98
to
2a010d3
Compare
908c281
to
73a608b
Compare
@metamask/composable-controller
from ^3.0.0
to ^9.1.0
@metamask/composable-controller
from ^3.0.0
to ^10.0.0
This comment was marked as outdated.
This comment was marked as outdated.
|
This comment was marked as duplicate.
This comment was marked as duplicate.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for platform
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for SDK, will validate in the next RC
Description
This commit updates
@metamask/composable-controller
to^10.0.0
.This involves fixing bugs outlined in #10073, and applying the major changes to the
ComposableController
API that has accumulated between the intervening versions.Blocked by
composable-controller
v10 has been written to ensure that the effect of this optimization is maximized.Global{Actions,Events}
#12407test: e2e fixes for #10441 #11162Changelog
Changed
@metamask/composable-controller
from^3.0.0
to^10.0.0
.ComposableController
class constructor optionmessenger
with aRestrictedControllerMessenger
instance derived from thecontrollerMessenger
class field instance ofEngine
, instead of passing in the unrestrictedcontrollerMessenger
instance directly.messenger
instance passed intoComposableController
constructor fromGlobalActions['type']
to an empty union.messenger
instance passed intoComposableController
constructor fromGlobalEvents['type']
to a union of thestateChange
events of all controllers included in theEngineState
type.EngineState
interface to use type alias syntax to ensure compatibility with types used in MetaMask controllers.Fixed
Engine
classdatamodel
field fromany
toComposableController<EngineState, StatefulControllers>
.CurrencyRatesController
constructor now normalizesnull
into 0 for theconversionRate
values of all native currencies keyed in thecurrencyRates
object ofCurrencyRatesControllerState
.ComposableController
constructor optioncontrollers
.Related issues
ComposableController
instantiation and functionality is broken #10073@metamask/[email protected]
release.@metamask/composable-controller
from^3.0.0
to^6.0.2
#10011Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist