Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exchange-rate-display component #9260

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Add exchange-rate-display component #9260

merged 2 commits into from
Aug 18, 2020

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Aug 18, 2020

This PR adds a component for displaying a rate of exchange between eth and a token, and an associated storybook story.

Demo gif:

exchangeRateDisplay

@danjm danjm requested a review from a team as a code owner August 18, 2020 13:56
@metamaskbot
Copy link
Collaborator

Builds ready [807acaa]
Page Load Metrics (653 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30112552412
domContentLoaded37491665113665
load37591765313665
domInteractive37491665113666

brad-decker
brad-decker suggested changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor nit.

ui/app/pages/token/exchange-rate-display/index.scss Outdated
}
}

.exchange-rate-display-white {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[REQ] could we make it --white and nest it?

@metamaskbot
Copy link
Collaborator

Builds ready [9787ca6]
Page Load Metrics (685 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30109522110
domContentLoaded6248766846029
load6268776856029
domInteractive6248756836029

jakehaugen
jakehaugen approved these changes Aug 18, 2020
View reviewed changes
Copy link

@jakehaugen jakehaugen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that spin!

@danjm danjm merged commit 74f0d47 into develop Aug 18, 2020
@danjm danjm deleted the exchange-rate-display branch August 18, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakehaugen jakehaugen jakehaugen approved these changes

@brad-decker brad-decker brad-decker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danjm @metamaskbot @brad-decker @jakehaugen