Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .network-name alignment #9152

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Fix .network-name alignment #9152

merged 1 commit into from
Aug 7, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Aug 6, 2020 •
edited
Loading

Fix .network-name alignment by removing its height property.

Screenshots from Chrome. Also tested in Firefox.

Before
After

@rekmarks rekmarks requested a review from a team as a code owner August 6, 2020 22:49
@rekmarks rekmarks requested a review from brad-decker August 6, 2020 22:49
@metamaskbot
Copy link
Collaborator

Builds ready [365a096]
Page Load Metrics (567 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30393531
domContentLoaded25265556510651
load25665656710550
domInteractive25165556510651

@brad-decker
Copy link
Contributor

Looks good!

@rekmarks rekmarks merged commit f18473a into develop Aug 7, 2020
@rekmarks rekmarks deleted the fix-network-name-height branch August 7, 2020 16:05
@Gudahtt Gudahtt mentioned this pull request Aug 7, 2020
Merged
@metamaskbot metamaskbot mentioned this pull request Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad-decker brad-decker brad-decker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @metamaskbot @brad-decker