Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support longer text in network dropdown #9085

Merged
merged 1 commit into from
Jul 27, 2020
Merged

support longer text in network dropdown #9085

merged 1 commit into from
Jul 27, 2020

Conversation

brad-decker
Copy link
Contributor

Fixes #6587

Verifying the issue was still active led to changing one line of css to fix the issue.

Before
After

@metamaskbot
Copy link
Collaborator

Builds ready [a36e2f2]
Page Load Metrics (665 ± 20 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3192502110
domContentLoaded5987586634220
load6007606654220
domInteractive5987576634220

@brad-decker brad-decker marked this pull request as ready for review July 27, 2020 18:17
@brad-decker brad-decker requested a review from a team as a code owner July 27, 2020 18:17
Gudahtt
Gudahtt approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brad-decker brad-decker merged commit 57715a8 into develop Jul 27, 2020
@brad-decker brad-decker deleted the fix-6587 branch July 27, 2020 20:01
Gudahtt pushed a commit that referenced this pull request Aug 7, 2020
@brad-decker @Gudahtt
support longer text in network dropdown (#9085)
7cf930f
@Gudahtt Gudahtt mentioned this pull request Aug 7, 2020
Merged
@metamaskbot metamaskbot mentioned this pull request Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alignment problem
3 participants
@brad-decker @metamaskbot @Gudahtt