Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@metamask/[email protected] #9046

Merged
merged 1 commit into from
Jul 21, 2020
Merged

@metamask/[email protected] #9046

merged 1 commit into from
Jul 21, 2020
+5 −5

Conversation

rekmarks
Copy link
Member

Fixes #9027
Fixes #9013

Fixes fetching site icons that are hosted on different origins (i.e, not same-origin).

@rekmarks rekmarks requested a review from a team as a code owner July 21, 2020 21:58
@rekmarks rekmarks mentioned this pull request Jul 21, 2020
Merged
@metamaskbot
Copy link
Collaborator

Builds ready [7b7338f]
Page Load Metrics (608 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint299143209
domContentLoaded3406756066431
load3426766086431
domInteractive3406756066431

@rekmarks rekmarks merged commit 3c9a51d into develop Jul 21, 2020
@rekmarks rekmarks deleted the @metamask/[email protected] branch July 21, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rekmarks @metamaskbot @whymarrh