Fix crash upon removing contact #9031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends upon #9030 |
Builds ready [fa426b5]
Page Load Metrics (592 ± 40 ms)
|
Base automatically changed from
hide-contact-delete-button-for-wallet-accounts
to
develop
July 17, 2020 23:30
The UI would crash upon deleting a contact from the contact list. This happened for two reasons: the deletion could result in a re-render before the `history.push` finished navigating back to the contact list (it was a race condition), and the contact entry left behind an invalid `identities` entry when it was removed. The first problem was fixed by making the container components for view and edit contact more tolerant of being passed an `address` that doesn't correspond to a contact. If they are given an address without a contact, `null` is passed to the component via the `address` prop. The component will redirect back to the list when this happens instead rendering. This is more awkward than I'd like, but it was the most sensible way of handling this I could think of without making much more drastic changes to how we're handling routing here. The second problem was caused by the `setAccountLabel` call, which was used to ensure the contact entry for any wallet accounts was kept in-sync with the account label. This was being called even for non- wallet accounts though, which is where this problem arose. This step is now skipped for non-wallet accounts. Fixes #9019
Gudahtt
force-pushed
the
fix-crash-upon-removing-contact
branch
from
fa426b5 to
31fcfc7
Compare
Builds ready [31fcfc7]
Page Load Metrics (588 ± 9 ms)
|
|
I had originally written a migration to remove any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI would crash upon deleting a contact from the contact list. This happened for two reasons: the deletion could result in a re-render before the
history.pushfinished navigating back to the contact list (it was a race condition), and the contact entry left behind an invalididentitiesentry when it was removed.The first problem was fixed by making the container components for view and edit contact more tolerant of being passed an
addressthat doesn't correspond to a contact. If they are given an address without a contact,nullis passed to the component via theaddressprop. The component will redirect back to the list when this happens instead rendering. This is more awkward than I'd like, but it was the most sensible way of handling this I could think of without making much more drastic changes to how we're handling routing here.The second problem was caused by the
setAccountLabelcall, which was used to ensure the contact entry for any wallet accounts was kept in-sync with the account label. This was being called even for non-wallet accounts though, which is where this problem arose. This step is now skipped for non-wallet accounts.Fixes #9019