Catch gas estimate errors #9025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two cases where bad gas estimate data was resulting in crashes. These two places have been wrapped in a `try ... catch` to handle the absence of gas estimate data. The errors are still reported to Sentry so that we can track down the root cause of this corrupted gas estimate data at some point in the future. We plan on adding additional context to Sentry soon that should help with this. Fixes #8992
|
Is there any extra context we want to add/should add? |
|
I'm wondering if there's anything we could add that would help us diagnose this further |
|
I was planning on separately re-adding the current Redux state to the Sentry context, minus anything big or identifying. That would include the gas and price estimates that are almost certainly responsible for this error. |
Builds ready [97484d6]
Page Load Metrics (606 ± 9 ms)
|
whymarrh
approved these changes
Jul 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two cases where bad gas estimate data was resulting in crashes. These two places have been wrapped in a
try ... catchto handle the absence of gas estimate data.The errors are still reported to Sentry so that we can track down the root cause of this corrupted gas estimate data at some point in the future. We plan on adding additional context to Sentry soon that should help with this.
Fixes #8992