Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear AccountTracker accounts and CachedBalances on createNewVaultAndRestore #9023

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Jul 16, 2020

Resets accounts in AccountTracker and CachedBalances when importing a new seed phrase, createNewVaultAndRestore is called.

@tmashuang tmashuang requested a review from a team as a code owner July 16, 2020 21:58
@metamaskbot
Copy link
Collaborator

Builds ready [b282364]
Page Load Metrics (665 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint288041147
domContentLoaded5827906646531
load5837916656531
domInteractive5817896636531

Gudahtt
Gudahtt previously approved these changes Jul 16, 2020
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I don't think this fixes the error shown, but clearing accounts and balances upon import does seem like a generally safe thing to do. There's probably some error this prevents.

@metamaskbot
Copy link
Collaborator

Builds ready [42c84ac]
Page Load Metrics (631 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint308443178
domContentLoaded4047386296230
load4067406316230
domInteractive4047386296230

@tmashuang tmashuang merged commit f02478e into develop Jul 17, 2020
@tmashuang tmashuang deleted the remove-accounts-accountTracker-cachedBalances branch July 17, 2020 02:09
@NutToKul

This comment has been minimized.

@metamaskbot metamaskbot mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants