Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web3_clientVersion method #8998

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Fix web3_clientVersion method #8998

merged 1 commit into from
Jul 15, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 15, 2020

This method was accidentally broken with the introduction of the permissions controller, as this was missing from the list of safe
methods.

It is now included in the list of safe methods.

Fixes #8993

@Gudahtt
Fix web3_clientVersion method
1d56b04 
This method was accidentally broken with the introduction of the
permissions controller, as this was missing from the list of safe
methods.

It is now included in the list of safe methods.

Fixes #8993
@Gudahtt Gudahtt marked this pull request as ready for review July 15, 2020 18:28
@Gudahtt Gudahtt requested a review from a team as a code owner July 15, 2020 18:28
whymarrh
whymarrh approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rekmarks
rekmarks approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [1d56b04]
Page Load Metrics (648 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31106542813
domContentLoaded4218506469847
load4238526489847
domInteractive4218506469847

@Gudahtt Gudahtt merged commit 0130108 into develop Jul 15, 2020
@Gudahtt Gudahtt deleted the fix-web3-client-version-method branch July 15, 2020 18:34
@levity levity mentioned this pull request Jul 16, 2020
Closed
@metamaskbot metamaskbot mentioned this pull request Jul 17, 2020
Merged
@tmashuang tmashuang mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web3_clientVersion RPC call returns an error
4 participants
@Gudahtt @metamaskbot @whymarrh @rekmarks