Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert transaction activity conversion's currency to ETH #8934

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Jul 7, 2020

Fixes #8933 where custom fromCurrency would crash the convertion utility and the UI.

This fixes in the mean time, but there still a separate issue with the nativeCurrency persisting in the background, it will reset to ETH upon background refresh.

See issue for before gif

Fix After Gif

@tmashuang tmashuang requested a review from a team as a code owner July 7, 2020 03:33
@metamaskbot
Copy link
Collaborator

Builds ready [1d47396]
Page Load Metrics (979 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45127762311
domContentLoaded4731332976225108
load4751334979225108
domInteractive4721332976225108

@tmashuang tmashuang force-pushed the fix-custom-rpc-activity-log branch from 1d47396 to fdb1281 Compare July 7, 2020 21:43
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I noticed we're passing in nativeCurrency as fromCurrency or toCurrency in other places as well, so similar bugs may still exist elsewhere.

@metamaskbot
Copy link
Collaborator

Builds ready [fdb1281]
Page Load Metrics (589 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint297939168
domContentLoaded34068558810651
load34168658910651
domInteractive33968558710651

@tmashuang tmashuang changed the title Convert all transaction activity to wei, and base from ETH Convert transaction activity conversion's currency to ETH Jul 7, 2020
@tmashuang tmashuang merged commit 15d713f into develop Jul 7, 2020
@tmashuang tmashuang deleted the fix-custom-rpc-activity-log branch July 7, 2020 22:15
@metamaskbot metamaskbot mentioned this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with TransactionActivityLog on custom rpc networks
3 participants