Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kovan chain ID constant #8913

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Fix Kovan chain ID constant #8913

merged 1 commit into from
Jul 3, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Jul 3, 2020

This restores the correct chain ID for Kovan.

I had hardcoded it to 0x42 during a momentary lapse of reason. 42 is its decimal network ID. The corresponding hex value and chain ID is 0x2a.

@rekmarks rekmarks requested a review from a team as a code owner July 3, 2020 16:57
Gudahtt
Gudahtt approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt mentioned this pull request Jul 3, 2020
Merged
@rekmarks rekmarks merged commit f97f95c into develop Jul 3, 2020
@rekmarks rekmarks deleted the fix-kovan-chain-id branch July 3, 2020 17:14
@metamaskbot
Copy link
Collaborator

Builds ready [4b600de]
Page Load Metrics (853 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36136682612
domContentLoaded453116085115173
load454116285315273
domInteractive453115985115173

@metamaskbot metamaskbot mentioned this pull request Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @metamaskbot @Gudahtt