Fix activity log inline buttons #8908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inline speedup and speedup cancellation buttons in the activity log were broken. An exception would be thrown upon either button being clicked, and nothing would happen from the user's perspective. Both handlers were being passed a transaction id, which was a holdover from before the transaction list redesign. The handlers passed for these two actions now have the transaction id embedded, so it doesn't need to be passed in anymore. They expect the click event to be passed through instead. The handlers passed also didn't handle closing the transaction details modal when clicked. After fixing the first problem, they still didn't work because the speedup/cancel dialog was shown behind the transaction details modal. Both issues are now fixed. Both buttons now close the transaction details modal, and trigger the appropriate action.
Gudahtt
force-pushed
the
fix-activity-log-inline-buttons
branch
from
8136c83 to
059a5b2
Compare
Builds ready [059a5b2]
Page Load Metrics (680 ± 62 ms)
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inline speedup and speedup cancellation buttons in the activity log were broken. An exception would be thrown upon either button being clicked, and nothing would happen from the user's perspective.
Both handlers were being passed a transaction id, which was a holdover from before the transaction list redesign. The handlers passed for these two actions now have the transaction id embedded, so it doesn't need to be passed in anymore. They expect the click event to be passed through instead.
The handlers passed also didn't handle closing the transaction details modal when clicked. After fixing the first problem, they still didn't work because the speedup/cancel dialog was shown behind the transaction details modal.
Both issues are now fixed. Both buttons now close the transaction details modal, and trigger the appropriate action.