Prevent manually connecting to extension UI #8893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfinlay
previously approved these changes
Jul 2, 2020
The `activeTab.id` property is relied upon in the connected sites modal to prevent the user from manually connecting to the MetaMask extension itself. Unfortunately the `id` property was never set. `id` is now set on the `activeTab` state, so manually connecting to the extension UI is now impossible.
Gudahtt
force-pushed
the
prevent-manually-connecting-to-extension-ui
branch
from
c47cc15 to
aa8b077
Compare
Builds ready [aa8b077]
Page Load Metrics (1015 ± 95 ms)
|
brad-decker
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
activeTab.idproperty is relied upon in the connected sites modal to prevent the user from manually connecting to the MetaMask extension itself. Unfortunately theidproperty was never set.idis now set on theactiveTabstate, so manually connecting to the extension UI is now impossible.