Set empty active tab if origin is invalid #8890
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `activeTab` state is now set to an empty object if the `origin` of the active tab is missing or invalid. It can be invalid if the URL passed to the `URL` constructor is missing a scheme (e.g. `about: blank`). There are currently no cases where the rest of the data in `activeTab` is useful in the absence of an `origin`. This will make upcoming UI logic changes a bit simpler than they would be otherwise. Now we can assume that if any property is set on `activeTab`, it must have a valid `origin`.
Builds ready [8c3a978]
Page Load Metrics (590 ± 46 ms)
|
whymarrh
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
activeTabstate is now set to an empty object if theoriginof the active tab is missing or invalid. It can be invalid if the URLpassed to the
URLconstructor is missing a scheme (e.g.about:blank).There are currently no cases where the rest of the data in
activeTabis useful in the absence of anorigin. This will make upcoming UI logic changes a bit simpler than they would be otherwise. Now we can assume that if any property is set onactiveTab, it must have a validorigin.