Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height / overflow behaviour of add token list #8874

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jun 30, 2020

This PR fixes the problem with the height / overflow of the add token lists that causes the page footer buttons to be hidden by the scroll. This can be seen below:

add-token-height-overflow

By setting min-height: 0; on the parent div of the overflowing elements, the problem is fixed (for reasons explained here: https://stackoverflow.com/a/26916542/4727685). The fix can be seen below:

add-token-height-overflow-fixed

The changed css rule is only used on the add token screen and in the gas modal. The gas modal remains unchanged after this change.

@danjm danjm requested a review from a team as a code owner June 30, 2020 11:14
@metamaskbot
Copy link
Collaborator

Builds ready [c913648]
Page Load Metrics (751 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30124602612
domContentLoaded561105074916579
load563105275116579
domInteractive561104974916579

@danjm danjm merged commit 14fa80c into develop Jul 1, 2020
@danjm danjm deleted the fix-add-token-list-height branch July 1, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants