Stop upper-casing exported private key #8850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were showing exported private keys in all upper case. This is atypical, and many other wallets (e.g. MyCrypto) expect private keys for imported accounts to be lower-cased. Our own account import is tolerant of either case.
|
This was pointed out here: brave/brave-browser#9837 (comment) |
|
It looks like the key was being upper-cased since the original implementation of this feature in #2171 |
Builds ready [eb898ab]
Page Load Metrics (767 ± 57 ms)
|
whymarrh
approved these changes
Jun 24, 2020
Gudahtt
added a commit
that referenced
this pull request
Jun 24, 2020
* origin/develop: Restore list item title attributes (#8858) Fix mobile sync redirect (#8860) Align copy tooltip text and icon (#8861) Update inpage provider, deprecation warnings (#8854) Update test-dapp (#8856) Return after 'reject' in Promise constructor (#8857) Replace removed 'copy-to-clipboard' icon (#8853) Stop upper-casing exported private key (#8850)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were showing exported private keys in all upper case. This is atypical, and many other wallets (e.g. MyCrypto) expect private keys for imported accounts to be lower-cased. Our own account import is tolerant of either case.