-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix grid repositioning on label change #8713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems promising! |
04e474e
to
f04029a
Compare
Builds ready [f04029a]
Page Load Metrics (712 ± 65 ms)
|
brad-decker
commented
Jun 1, 2020
978ef2a
to
e27f7ad
Compare
Builds ready [bffabc8]
Page Load Metrics (712 ± 80 ms)
|
Gudahtt
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -1,7 +1,8 @@ | |||
.toggle-button { | |||
display: flex; | |||
$self: &; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh... I didn't know you could assign &
to a variable! That's neat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8687
Takes advantage of visibility: hidden/visible which does not remove the space the element takes up on the screen from the dom... as well as a single column/row grid to overlap both off/on labels in the toggle button. I'm not used to BEM syntax so I'm sure the class naming could use some work.
This works for the alert screen because max-content will include visibility: hidden items.
For this demo i modified the HTML content to a longer off statement:
Mixed toggles
Both on