do not display extension id in connection modal #8699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
requested changes
May 29, 2020
| @@ -50,7 +51,7 @@ export default class ConnectedAccounts extends PureComponent { | |||
|
|
|||
| return ( | |||
| <Popover | |||
| title={activeTabOrigin} | |||
| title={activeTabOrigin === extension.runtime.id ? t('currentExtension') : activeTabOrigin} | |||
There was a problem hiding this comment.
Hm, this will only do it for the MetaMask extension itself, no? I'm just realizing, that's probably a bad idea. We should probably prevent the extension UI from initiating an external permissions request to itself.
That's a different issue. Meanwhile, is there any platform-agnostic way of detecting an extension ID here?
There was a problem hiding this comment.
hmm good point lol.
There was a problem hiding this comment.
window.location.protocol seems promising... 'chrome-extension' 'moz-extension' etc
Builds ready [1f0ce51]
Page Load Metrics (671 ± 82 ms)
|
Gudahtt
added a commit
that referenced
this pull request
Jun 1, 2020
* origin/develop: (689 commits) Implement asset page (#8696) fix crash on signature request (#8709) Fix accounts menu styling (#8707) Delete docs/porting_to_new_environment.md (#8704) Remove unused `getToErrorObject` parameters (#8705) hide connected-status on metamask ext (#8703) Stop adding permissions middleware to trusted connections (#8701) Use `send` state for send flow token (#8695) do not display extension id in connection modal (#8699) Fix tab content disappearing during scrolling on macOS Firefox (#8702) close details when button is pressed (#8694) Refactor token selectors (#8671) Update eth_accounts permission description (#8693) Extract selected token from token input (#8692) Fix propType for Home defaultHomeActiveTabName (#8683) Fix create account form styling (#8689) Remove unused `getSelectedTokenAssetImage` selector (#8691) Remove `getTxParams` (#8676) do not show account mismatch alert on details (#8678) Fix connect hardware styling (#8680) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8685
Before
After