Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics events for Wyre and CoinSwitch #8677

Merged
merged 1 commit into from
May 28, 2020

Conversation

whymarrh
Copy link
Contributor

Closes #7699

This PR adds metrics events for the ETH purchase buttons.

onButtonClick: () => {
this.context.metricsEvent({
eventOpts: {
category: 'Onboarding',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Onboarding category make sense here? 🤔

Copy link
Contributor Author

@whymarrh whymarrh May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is primarily a way to onboard people

Copy link
Member

@Gudahtt Gudahtt May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really? It's a way to buy Eth. Existing users need to buy Eth sometimes too. It's not even presented during onboarding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use "Accounts"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have a different suggestion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "On-Ramp"? Or "Integrations", or "Third-Party", or "Exchange"? 🤷‍♂️
A new category would just have this one action type in it, but that's not unprecedented. We'll likely have more related metrics soon as well.

I guess "Accounts" is fine too.

@whymarrh whymarrh marked this pull request as ready for review May 28, 2020 16:13
@whymarrh whymarrh requested a review from a team as a code owner May 28, 2020 16:13
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 93c2184 into MetaMask:develop May 28, 2020
@whymarrh whymarrh deleted the ether-events branch May 28, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics event for completed eth purchase
2 participants