Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token decimal type #8670

Merged
merged 1 commit into from
May 28, 2020
Merged

Fix token decimal type #8670

merged 1 commit into from
May 28, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 28, 2020

The decimals property of tokens was being set as a string instead of a Number for any tokens added via getTokenParams. It's now cast to a Number instead.

This caught my attention because of prop type warnings.

@Gudahtt
Fix token decimal type
9d2d854 
The `decimals` property of tokens was being set as a string instead of
a Number for any tokens added via `getTokenParams`. It's now cast to a
Number instead.

This caught my attention because of prop type warnings.
@Gudahtt Gudahtt requested a review from a team as a code owner May 28, 2020 00:15
@metamaskbot
Copy link
Collaborator

Builds ready [9d2d854]
Page Load Metrics (642 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3110744199
domContentLoaded34481964012962
load34582064212962
domInteractive34481864012962

@Gudahtt Gudahtt merged commit e89540f into develop May 28, 2020
@Gudahtt Gudahtt deleted the fix-token-decimals-type branch May 28, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @whymarrh