Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually connect via the full connect flow #8666

Merged
merged 2 commits into from
May 28, 2020

Conversation

whymarrh
Copy link
Contributor

This PR updates the Connected sites modal to initiate the full connect flow when "manually" connecting to the active tab.

@whymarrh whymarrh marked this pull request as ready for review May 28, 2020 00:39
@whymarrh whymarrh requested a review from a team as a code owner May 28, 2020 00:39
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for merge conflicts

@whymarrh whymarrh merged commit 5da369d into MetaMask:develop May 28, 2020
@whymarrh whymarrh deleted the manual-connect branch May 28, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants