Make address display wider in Account Details #8665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
previously approved these changes
May 27, 2020
Gudahtt
reviewed
May 27, 2020
| @@ -403,10 +403,10 @@ textarea.twelve-word-phrase { | |||
| } | |||
|
|
|||
| .qr-ellip-address, .ellip-address { | |||
| /*rtl:ignore*/ | |||
There was a problem hiding this comment.
Why was this removed? I think this is still required to prevent the direction of the address from being flipped when using a RTL locale
There was a problem hiding this comment.
Is... is this comment used? 🤦
There was a problem hiding this comment.
Yes - the rtl comments are directives for rtlcss, which we use via gulp-rtlcss
There was a problem hiding this comment.
I've added it back, that's unfortunate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the address display wider on the Account Details page.
Before & after: