Define global web3
as non-enumerable
#8634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We inject
web3
globally on most websites. This has been breaking websites that attempted to serialize thewindow
object, because any attempt to access certainweb3
properties (such asweb3.eth.mining
) would throw an error. This is becauseweb3
defined a getter for these properties that would call.send([method])
, which doesn't work for most methods.An example of a site that this breaks is
Storybook
, when the@storybook/addon-actions
addon is being used. When using storybook with this addon and with the MetaMask extension installed, actions would not be properly dispatched because an error would be thrown in the attempt to serialize the event (which includes a reference to thewindow
).The
web3
global we inject is now defined as non-enumerable, so it will be skipped automatically in any attempt to serialize thewindow
object.