feature/sync imported accounts with mobile

[estebanmino]

The purpose of this PR is to send data of imported accounts to mobile app while doing sync. Related PR on mobile MetaMask/metamask-mobile#1591

[metamaskbot]

Builds ready [ea1f89f]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (594 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	84	38	11	5
		domContentLoaded	337	760	592	105	51
		load	339	760	594	105	51
		domInteractive	337	759	592	105	51

[metamaskbot]

Builds ready [16ebe5d]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (810 ± 39 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	29	132	59	31	15
		domContentLoaded	461	869	808	81	39
		load	463	871	810	81	39
		domInteractive	461	869	808	81	39

[Gudahtt]

It looks like something went wrong when you tried resolving that conflict. Lots of deleted files.

[Gudahtt]

I've rebased the first two commits onto develop, re-resolving the conflicts to avoid the deletions

[metamaskbot]

Builds ready [5dd8bfd]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (701 ± 29 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	31	87	48	19	9
		domContentLoaded	633	861	700	61	29
		load	634	862	701	61	29
		domInteractive	632	860	699	61	29

[Gudahtt]

It looks like this results in the duplication of all accounts when you have two or more imported accounts (as you discovered and reported on Slack).

This is happening because submitPassword is called as part of the exportAccount action, which is now being called multiple times asynchronously. submitPassword should never be called while another submitPassword call is still resolving, because it will dump and re-add all keyrings. So in this case, if you have two imported accounts, it will re-add all keyrings twice resulting in duplicate accounts.

There are a few different ways I can think of to fix this:

1. Separate the password validation step from the exportAccount step. We could update the exportAccount action to just export the account, and verify the password separately.
2. Export accounts one-at-a-time, instead of in parallel.
3. Add a method to the keyring controller to validate the password without dumping and re-adding all keyrings, and use that here instead.

The simplest solution would be 2), but 1) and 3) are things we should probably do regardless, just to make this faster and less flaky.

[estebanmino]

@Gudahtt ok thanks for that context, I'll fix it

[estebanmino]

@Gudahtt I created a new action method called exportAccounts to fix this.
I didn't do

1. because i didn't want to break what's currently working on the extension (that I also don't have context of)
2. I agree with you

In a sense I did 3. but not at Keyring Controller level, just an action that checks if the password is correct once, after that is validated it goes to get the private keys to the Keychain, following what exportAccount does now.

WDYT?

[Gudahtt]

Seems like a good solution!

[metamaskbot]

Builds ready [84816d9]

• builds: chrome, firefox, opera
• bundle viz: background, ui, inpage, contentscript, ui-libs, bg-libs, phishing-detect
• dep viz: background
• all artifacts

Page Load Metrics (729 ± 57 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	34	134	55	27	13
		domContentLoaded	376	1010	727	118	57
		load	377	1011	729	118	57
		domInteractive	376	1009	727	118	57