Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected accounts secondary sort order #8608

Merged
merged 1 commit into from
May 18, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 18, 2020

The connected accounts are now ordered by keyring controller order whenever the lastSelected time is equal. This ensures the order is identical to what connected sites see. This is especially important when no accounts have been selected, as it ensures the correct account is marked as the "Primary" account.

The connected accounts are now ordered by keyring controller order
whenever the `lastSelected` time is equal. This ensures the order is
identical to what connected sites see. This is especially important
when no accounts have been selected, as it ensures the correct account
is marked as the "Primary" account.
@metamaskbot
Copy link
Collaborator

Builds ready [86c8e3a]
Page Load Metrics (602 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint318439115
domContentLoaded34680460014871
load34880760214871
domInteractive34680460014871

@Gudahtt Gudahtt marked this pull request as ready for review May 18, 2020 15:30
@Gudahtt Gudahtt requested a review from a team as a code owner May 18, 2020 15:30
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--> Legitimacy detected <--

@Gudahtt Gudahtt merged commit 0033a64 into develop May 18, 2020
@Gudahtt Gudahtt deleted the connected-accounts-secondary-order branch May 18, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants