Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Matomo dimension IDs #8579

Merged
merged 1 commit into from
May 13, 2020
Merged

Fix Matomo dimension IDs #8579

merged 1 commit into from
May 13, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 13, 2020

The IDs for the numberOfTokens and numberOfAccounts Action Dimensions were swapped. These are the correct IDs. We'll have to consider that these are swapped when viewing any pre-v8.0.0 metrics.

@Gudahtt Gudahtt requested a review from jennypollack May 13, 2020 05:26
@Gudahtt Gudahtt requested a review from a team as a code owner May 13, 2020 05:26
@metamaskbot
Copy link
Collaborator

Builds ready [ec7fe87]
Page Load Metrics (731 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33111572311
domContentLoaded6717967293919
load6737987314019
domInteractive6707967283919

whymarrh
whymarrh suggested changes May 13, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick

ui/app/helpers/utils/metametrics.util.js Outdated Show resolved Hide resolved
@whymarrh
Copy link
Contributor

What's the canonical source for these IDs?

@Gudahtt
Fix Matomo dimension IDs
0b6abaf 
The IDs for the `numberOfTokens` and `numberOfAccounts` Action
Dimensions were swapped. These are the correct IDs. We'll have to
consider that these are swapped when viewing any pre-v8.0.0 metrics.
@Gudahtt Gudahtt force-pushed the fix-matomo-dimension-ids branch from ec7fe87 to 0b6abaf Compare May 13, 2020 12:38
@Gudahtt
Copy link
Member Author

Gudahtt commented May 13, 2020

The canonical source for these IDs is our Matomo account, which shows these under the settings (probably only for admins unfortunately).

Screenshot:

action_dimensions

@metamaskbot
Copy link
Collaborator

Builds ready [0b6abaf]
Page Load Metrics (645 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31543863
domContentLoaded3738046439345
load3748066459345
domInteractive3728046439345

whymarrh
whymarrh approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 7a4eece into develop May 13, 2020
@Gudahtt Gudahtt deleted the fix-matomo-dimension-ids branch May 13, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@jennypollack jennypollack Awaiting requested review from jennypollack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @metamaskbot @whymarrh