Update tokens after importing account #8491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tokens are now updated when the account switches after a failed account import. The usual account switching flow (via the account menu) already updated tokens, but this step was omitted when the account switched after a failed import.
|
This is required for an upcoming PR for v8.0.0 (the alert upon opening the popup when an unconnected account is selected). Ideally this would get replaced with a full background state update, rather than just a token update. But that might have performance implications, and I'd rather not looking into that right now. For now at least we're consistent between these two actions. |
Builds ready [502d1f4]
Page Load Metrics (625 ± 10 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokens are now updated when the account switches after a failed account import. The usual account switching flow (via the account menu) already updated tokens, but this step was omitted when the account switched after a failed import.