Refactor analyzeGasUsage to return results
#8487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`analyzeGasUsage` now returns the results of the analysis rather than setting them directly on `txMeta`. The caller is now responsible for mutating `txMeta` instead. Functionally this should be identical to before.
Gudahtt
force-pushed
the
refactor-analyze-gas-usage
branch
from
f31b863 to
153b6e5
Compare
Gudahtt
changed the base branch from
skip-gas-limit-estimation-when-specified
to
develop
Builds ready [153b6e5]
Page Load Metrics (651 ± 19 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analyzeGasUsagenow returns the results of the analysis rather than setting them directly ontxMeta. The caller is now responsible for mutatingtxMetainstead. Functionally this should be identical to before.