-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "Add Dai/Sai to currency display (#7986)" #8455
Merged
Gudahtt
merged 1 commit into
Version-v7.7.9
from
backport-add-dai-sai-currency-conversion-display
Apr 29, 2020
Merged
Backport "Add Dai/Sai to currency display (#7986)" #8455
Gudahtt
merged 1 commit into
Version-v7.7.9
from
backport-add-dai-sai-currency-conversion-display
Apr 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
backport-cleanup-currency-conversion
branch
from
April 29, 2020 05:17
ec7204a
to
37dad37
Compare
Gudahtt
force-pushed
the
backport-add-dai-sai-currency-conversion-display
branch
from
April 29, 2020 05:18
8990eb8
to
f6fc4ff
Compare
This depends upon #8454 |
Gudahtt
force-pushed
the
backport-cleanup-currency-conversion
branch
from
April 29, 2020 05:32
37dad37
to
47bb376
Compare
Gudahtt
force-pushed
the
backport-add-dai-sai-currency-conversion-display
branch
from
April 29, 2020 05:33
f6fc4ff
to
039a204
Compare
Builds ready [039a204]
|
Gudahtt
force-pushed
the
backport-cleanup-currency-conversion
branch
from
April 29, 2020 15:35
47bb376
to
fea68c8
Compare
Gudahtt
force-pushed
the
backport-add-dai-sai-currency-conversion-display
branch
from
April 29, 2020 15:36
039a204
to
280f178
Compare
Builds ready [280f178]
|
Gudahtt
force-pushed
the
backport-cleanup-currency-conversion
branch
from
April 29, 2020 17:10
fea68c8
to
c7eaf47
Compare
Gudahtt
force-pushed
the
backport-add-dai-sai-currency-conversion-display
branch
from
April 29, 2020 18:38
280f178
to
7c76e54
Compare
Gudahtt
changed the base branch from
backport-cleanup-currency-conversion
to
Version-v7.7.9
April 29, 2020 18:38
Gudahtt
changed the title
Backport "Fixes #5706 - Adds Dai/Sai to currency display (#7986)"
Backport "Add Dai/Sai to currency display (#7986)"
Apr 29, 2020
Builds ready [7c76e54]
|
Gudahtt
force-pushed
the
backport-add-dai-sai-currency-conversion-display
branch
from
April 29, 2020 19:20
7c76e54
to
b56d36b
Compare
rekmarks
previously approved these changes
Apr 29, 2020
Builds ready [b56d36b]
|
whymarrh
previously approved these changes
Apr 29, 2020
Backport #7986 onto v7.7.9. The original commit message follows: With the change from infura to cryptocompare https://github.com/MetaMask/gaba/pull/30/files#diff-50c3c47cc5fa12e5213a6cc900476f41L41-R48 we have numerous conversion rates to go through and add if we like to.
Gudahtt
force-pushed
the
backport-add-dai-sai-currency-conversion-display
branch
from
April 29, 2020 20:02
b56d36b
to
676598b
Compare
Builds ready [676598b]
|
rekmarks
approved these changes
Apr 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #7986 onto v7.7.9. The original commit message follows:
With the change from infura to cryptocompare https://github.com/MetaMask/gaba/pull/30/files#diff-50c3c47cc5fa12e5213a6cc900476f41L41-R48 we have numerous conversion rates to go through and add if we like to.