Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Add Dai/Sai to currency display (#7986)" #8455

Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 29, 2020

Backport #7986 onto v7.7.9. The original commit message follows:

With the change from infura to cryptocompare https://github.com/MetaMask/gaba/pull/30/files#diff-50c3c47cc5fa12e5213a6cc900476f41L41-R48 we have numerous conversion rates to go through and add if we like to.

@Gudahtt Gudahtt force-pushed the backport-cleanup-currency-conversion branch from ec7204a to 37dad37 Compare April 29, 2020 05:17
@Gudahtt Gudahtt force-pushed the backport-add-dai-sai-currency-conversion-display branch from 8990eb8 to f6fc4ff Compare April 29, 2020 05:18
@Gudahtt
Copy link
Member Author

Gudahtt commented Apr 29, 2020

This depends upon #8454

@Gudahtt Gudahtt force-pushed the backport-cleanup-currency-conversion branch from 37dad37 to 47bb376 Compare April 29, 2020 05:32
@Gudahtt Gudahtt force-pushed the backport-add-dai-sai-currency-conversion-display branch from f6fc4ff to 039a204 Compare April 29, 2020 05:33
@metamaskbot
Copy link
Collaborator

Builds ready [039a204]

@Gudahtt Gudahtt force-pushed the backport-cleanup-currency-conversion branch from 47bb376 to fea68c8 Compare April 29, 2020 15:35
@Gudahtt Gudahtt force-pushed the backport-add-dai-sai-currency-conversion-display branch from 039a204 to 280f178 Compare April 29, 2020 15:36
@metamaskbot
Copy link
Collaborator

Builds ready [280f178]

@Gudahtt Gudahtt force-pushed the backport-cleanup-currency-conversion branch from fea68c8 to c7eaf47 Compare April 29, 2020 17:10
@Gudahtt Gudahtt force-pushed the backport-add-dai-sai-currency-conversion-display branch from 280f178 to 7c76e54 Compare April 29, 2020 18:38
@Gudahtt Gudahtt changed the base branch from backport-cleanup-currency-conversion to Version-v7.7.9 April 29, 2020 18:38
@Gudahtt Gudahtt changed the title Backport "Fixes #5706 - Adds Dai/Sai to currency display (#7986)" Backport "Add Dai/Sai to currency display (#7986)" Apr 29, 2020
@metamaskbot
Copy link
Collaborator

Builds ready [7c76e54]

@Gudahtt Gudahtt force-pushed the backport-add-dai-sai-currency-conversion-display branch from 7c76e54 to b56d36b Compare April 29, 2020 19:20
@Gudahtt Gudahtt marked this pull request as ready for review April 29, 2020 19:34
@Gudahtt Gudahtt requested review from danjm and whymarrh as code owners April 29, 2020 19:34
@Gudahtt Gudahtt requested a review from a team April 29, 2020 19:34
rekmarks
rekmarks previously approved these changes Apr 29, 2020
@metamaskbot
Copy link
Collaborator

Builds ready [b56d36b]

whymarrh
whymarrh previously approved these changes Apr 29, 2020
Backport #7986 onto v7.7.9. The original commit message follows:

With the change from infura to cryptocompare https://github.com/MetaMask/gaba/pull/30/files#diff-50c3c47cc5fa12e5213a6cc900476f41L41-R48 we have numerous conversion rates to go through and add if we like to.
@Gudahtt Gudahtt dismissed stale reviews from whymarrh and rekmarks via 676598b April 29, 2020 20:02
@Gudahtt Gudahtt force-pushed the backport-add-dai-sai-currency-conversion-display branch from b56d36b to 676598b Compare April 29, 2020 20:02
@metamaskbot
Copy link
Collaborator

Builds ready [676598b]

@Gudahtt Gudahtt merged commit 361c571 into Version-v7.7.9 Apr 29, 2020
@Gudahtt Gudahtt deleted the backport-add-dai-sai-currency-conversion-display branch April 29, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants